Use lowercased method name convention#9
Merged
jparise merged 2 commits intoInstapaper:mainfrom Mar 31, 2026
Merged
Conversation
This renames the Article, PDF, and Summary methods to lowercase, matching standard Python naming conventions and avoiding any overlap with the model type names. We have aliases for the previous names for backwards compatibility.
Donohue
approved these changes
Mar 31, 2026
Contributor
Donohue
left a comment
Donohue
left a comment
There was a problem hiding this comment.
Approved but before shipping we will need to update this on the Instaparser website homepage, quick start guides, etc.
Contributor
|
On second thought, I think this will break compatibility for older clients? How do you think about that? |
Member
Author
We have these aliases that allow the existing names to still work: # Aliases for backwards compatibility:
Article = article
PDF = pdf
Summary = summary |
Member
Author
|
In addition to the aliases, we now emit a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames the Article, PDF, and Summary methods to lowercase, matching standard Python naming conventions and avoiding any overlap with the model type names.
We have aliases for the previous names for backwards compatibility.